Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy asynccontextmanager import from _helpers #1146

Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Remove legacy asynccontextmanager import from _helpers

Assumptions

_helpers.py is not part of the public API

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Aug 18, 2024
@jakob-keller jakob-keller enabled auto-merge August 18, 2024 16:09
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (6179c56) to head (ad0b581).
Report is 110 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
+ Coverage   86.21%   86.24%   +0.02%     
==========================================
  Files          62       62              
  Lines        5950     5945       -5     
==========================================
- Hits         5130     5127       -3     
+ Misses        820      818       -2     
Flag Coverage Δ
unittests 86.24% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit 089ce8c into aio-libs:master Aug 18, 2024
11 checks passed
@jakob-keller jakob-keller deleted the remove-helpers-asynccontextmanager branch August 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant