Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize docs #1165

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Modernize docs #1165

merged 2 commits into from
Aug 21, 2024

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Closes #1161

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the documentation Improvements or additions to documentation label Aug 21, 2024
@jakob-keller jakob-keller self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (d80e20d) to head (e6b1a3e).
Report is 71 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1165   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files          64       64           
  Lines        5978     5978           
=======================================
  Hits         5197     5197           
  Misses        781      781           
Flag Coverage Δ
unittests 86.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jakob-keller jakob-keller marked this pull request as ready for review August 21, 2024 10:04
@jakob-keller jakob-keller requested a review from thehesiod August 21, 2024 10:06
pyproject.toml Outdated Show resolved Hide resolved
.readthedocs.yml Outdated Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this, is good assuming that consolidating sphinx runs would be done separately.

@jakob-keller jakob-keller enabled auto-merge August 21, 2024 14:39
@jakob-keller jakob-keller merged commit 1fcc8b9 into aio-libs:master Aug 21, 2024
11 checks passed
@jakob-keller jakob-keller deleted the modernize-docs branch August 21, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve version via importlib.metadata in docs/conf.py
2 participants