Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yamllint pre-commit hook #1173

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Aug 22, 2024

Description of Change

Closes #1168, closes #1175

Assumptions

Strings in this repo's YAML documents are frequently encapsulated in a pair of single or double quotes, which is unnecessary in many cases. Harmonizing those is not in scope of this PR.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller marked this pull request as ready for review August 22, 2024 18:21
@jakob-keller jakob-keller self-assigned this Aug 22, 2024
@jakob-keller jakob-keller requested a review from webknjaz August 22, 2024 18:23
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (8af27ac) to head (03424e1).
Report is 65 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
- Coverage   86.98%   86.93%   -0.06%     
==========================================
  Files          64       64              
  Lines        5978     5978              
==========================================
- Hits         5200     5197       -3     
- Misses        778      781       +3     
Flag Coverage Δ
unittests 86.93% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

.github/FUNDING.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@webknjaz
Copy link
Member

By the way, I've gone ahead and enabled pre-commit.ci for this repo.

Here's a badge to integrate into README:

image:: https://results.pre-commit.ci/badge/github/aio-libs/aiobotocore/master.svg
   :target: https://results.pre-commit.ci/latest/github/aio-libs/aiobotocore/master
   :alt: pre-commit.ci status

@jakob-keller jakob-keller merged commit 7ebcf83 into aio-libs:master Aug 22, 2024
11 checks passed
@jakob-keller jakob-keller deleted the yamllint branch August 22, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add badge for pre-commit.ci Standardize YAML format
2 participants