Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify strings are now correctly passed to aiohttp.TCPConnector #851

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

FHTMitchell
Copy link
Contributor

@FHTMitchell FHTMitchell commented Feb 9, 2021

Description of Change

Fix bug where verify arguments of type str weren't being used correctly (see #850). This is done by passing verify to the ssl.create_default_context method which is then passed to aiohttp.TCPConnector.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@thehesiod
Copy link
Collaborator

awesome ty! could you add yourself to the list of contributors and create a new 1.2.0 section under CHANGES.rst and add this change? I'll publish after we merge

@thehesiod thehesiod self-requested a review February 10, 2021 02:29
@thehesiod thehesiod merged commit 9e7a608 into aio-libs:master Feb 10, 2021
@thehesiod
Copy link
Collaborator

actually I'll do it since I need to remove travis anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If you pass a string verify path to create_client, you will get a ClientConnectorCertificateError
2 participants