Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce passing in an instance of the aiohttp resolver, not a class #906

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Enforce passing in an instance of the aiohttp resolver, not a class #906

merged 1 commit into from
Dec 14, 2021

Conversation

orf
Copy link
Contributor

@orf orf commented Dec 10, 2021

I'm sorry, with #893 I made a mistake: You need to pass in an instance of the resolver and not the class itself 😞

This fixes that.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #906 (8c0adce) into master (f269b8e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   89.30%   89.30%   -0.01%     
==========================================
  Files          42       42              
  Lines        4573     4572       -1     
==========================================
- Hits         4084     4083       -1     
  Misses        489      489              
Flag Coverage Δ
unittests 89.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_config.py 100.00% <ø> (ø)
aiobotocore/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f269b8e...8c0adce. Read the comment docs.

@thehesiod thehesiod merged commit 4dff809 into aio-libs:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants