Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit to the CI #967

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Sep 9, 2022

Description of Change

I noticed that pre-commit was changing some files, therefore I think it is good to add it to the CI to make sure that everything stays nice and clean.

Also bumped the versions while at it.

Assumptions

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

I noticed that pre-commit was changing some files, therefore I think
it is good to add it to the CI to make sure that everything stays nice
and clean.

Also bumped the versions while at it.
@thehesiod thehesiod enabled auto-merge (squash) September 19, 2022 23:58
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #967 (5769028) into master (585d6ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #967   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files          55       55           
  Lines        5322     5322           
=======================================
  Hits         4618     4618           
  Misses        704      704           
Flag Coverage Δ
unittests 86.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thehesiod thehesiod disabled auto-merge September 20, 2022 00:02
@thehesiod thehesiod enabled auto-merge (squash) October 3, 2022 19:40
@thehesiod thehesiod disabled auto-merge October 3, 2022 19:40
@thehesiod thehesiod merged commit e9b8ab4 into aio-libs:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants