Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #977

Merged
merged 13 commits into from
Jul 7, 2023
Merged

Add support for Python 3.11 #977

merged 13 commits into from
Jul 7, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 29, 2022

Description of Change

Python 3.11 was released on 2022-10-24.

image

Add 3.11 to CI and Trove classifiers. Also bump GitHub Actions and drop the dot in py.test.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to support 3.11

@phillipuniverse
Copy link

Looks like we will need to also update botocore to at least 1.29.13 to remove new DeprecationWarning.

../../Library/Caches/pypoetry/virtualenvs/tabula-3sZz9FDu-py3.11/lib/python3.11/site-packages/aioboto3/__init__.py:5: in <module>
    from aioboto3.session import Session
../../Library/Caches/pypoetry/virtualenvs/tabula-3sZz9FDu-py3.11/lib/python3.11/site-packages/aioboto3/session.py:9: in <module>
    import aiobotocore.session
../../Library/Caches/pypoetry/virtualenvs/tabula-3sZz9FDu-py3.11/lib/python3.11/site-packages/aiobotocore/session.py:1: in <module>
    from botocore import UNSIGNED, translate
../../Library/Caches/pypoetry/virtualenvs/tabula-3sZz9FDu-py3.11/lib/python3.11/site-packages/botocore/translate.py:16: in <module>
    from botocore.utils import merge_dicts
../../Library/Caches/pypoetry/virtualenvs/tabula-3sZz9FDu-py3.11/lib/python3.11/site-packages/botocore/utils.py:15: in <module>
    import cgi
../../.pyenv/versions/3.11.1/lib/python3.11/cgi.py:57: in <module>
    warnings._deprecated(__name__, remove=(3,13))
../../.pyenv/versions/3.11.1/lib/python3.11/warnings.py:514: in _deprecated
    warn(msg, DeprecationWarning, stacklevel=3)
E   DeprecationWarning: 'cgi' is deprecated and slated for removal in Python 3.13

See boto/botocore@de07ce2

@thehesiod
Copy link
Collaborator

thehesiod commented Mar 7, 2023

@hugovk we've finally bumped, could you merge/re-base and set to 2.5.1?

@hugovk
Copy link
Contributor Author

hugovk commented Mar 7, 2023

Rebased!

@thehesiod thehesiod enabled auto-merge (squash) July 7, 2023 06:20
@thehesiod
Copy link
Collaborator

sorry for the delay! I added this in the last release but will add these enhancements

@thehesiod
Copy link
Collaborator

bit rot!

@thehesiod
Copy link
Collaborator

@hugovk it doesn't like something about ERROR: Failed to resolve requirement from line: -e .[awscli,boto3] in 3.9 with these changes, not sure what's going on as I don't see how this could have broken the build

@thehesiod
Copy link
Collaborator

ooo, because this is a development version now

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #977 (c53d7d9) into master (0f5447b) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
- Coverage   86.25%   86.20%   -0.06%     
==========================================
  Files          58       58              
  Lines        5735     5735              
==========================================
- Hits         4947     4944       -3     
- Misses        788      791       +3     
Flag Coverage Δ
unittests 86.20% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_version.py 94.33% <100.00%> (-2.84%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thehesiod thehesiod merged commit 011efa0 into aio-libs:master Jul 7, 2023
@hugovk hugovk deleted the add-3.11 branch July 7, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants