-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssertionError only with versions 2.4.1 and 2.4.2 #100
Comments
Bisecting would be useful, if course. It sounds it might be necessary to use a fuzzer to reproduce. I wonder if writing hypothesis tests could reveal some corner cases... |
I did bisect, and it's definitely 2.4.2 - the new classes added there are causing this. |
It would be great if you could come up with a minimum reproducer. This code is copied from cpython main so we will need to let them know as well. |
Within 2.4.2, do we have a specific commit causing this? |
Also, is this serious enough to yank the version from PyPI? |
As far as I am concerned, I had to rollback to 2.4.1. I just can't use 2.4.2, it crashes immediately, again and again. Unfortunately, I can't today dig into this (extracting a reproducible case) but clearly 2.4.2 is not functional, at least for aiohttp client use cases similar to mine (crawling a few websites, only a few hundred pages per day). |
2.4.2 is made of 2 commits: The second one (04dbbe5) is dedicated only to updating the version numbers from 2.4.1 to 2.4.2. |
I made a big mistake (sorry for that I relied on the conda installer and did not see it did not have 2.4.1 available) - I thought I had tested 2.4.1 successfully but my package installer (conda forge) had installed 2.4.0. After re-running everything, it is indeed 2.4.1 which is faulty. It has several commits so I don't know yet which one is wrong (I will have to bisect) |
Even if we revert, we end up with the code that is going out in the next cpython 3.12 since that’s where it comes from I don’t see a solution other than rolling our own to fix the problem |
I can reproduce with the tests I added in #101
|
I've marked 2.4.2 as yanked on PyPI. |
2.4.1 is also contaminated by this bug (see analysis - and my initial mistake - above) |
@bdraco deduced that it's not possible |
The assertion line referenced in the opening text does not appear in 2.4.1 _staggered.py is not in 2.4.1 |
Describe the bug
Running the most recent versions of
aiohappyeyeballs
(2.4.2) withaiohttp
triggers anAssertionError
withinaiohappyeyeballs
:Running the exact same code with
aiohappyeyeballs
2.4.1 or 2.4.0 triggers no such bug.To Reproduce
No clear steps, as this is generated by a crawler with a lot of URIs. Could try to extract a simple case if this is necessary.
Additional context
Python artifacts:
Installed through miniforge:
OS:
The text was updated successfully, but these errors were encountered: