Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite staggered_race to be race safe #101

Merged
merged 59 commits into from
Sep 30, 2024
Merged

fix: rewrite staggered_race to be race safe #101

merged 59 commits into from
Sep 30, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 30, 2024

What do these changes do?

We keep using stdlib asyncio.staggered.staggered_race and we keep having issues with it

While I hate to maintain our own, it seems like we need to do this

Are there changes in behavior for the user?

bugfix

Related issue number

fixes #100
fixes #99
fixes #96
#93 - maybe related, unknown
#97 - this looks like a deeper problem
aio-libs/aiohttp#8599 - this is what the new implementation from stdlib was intended to solve but it has other regressions

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b075f25) to head (9fd0030).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #101   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         5    -1     
  Lines          198       227   +29     
  Branches        45        60   +15     
=========================================
+ Hits           198       227   +29     
Flag Coverage Δ
99.55% <100.00%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title feat: rewrite staggered_race to be race safe fix: rewrite staggered_race to be race safe Sep 30, 2024
@bdraco bdraco marked this pull request as ready for review September 30, 2024 19:37
@bdraco bdraco merged commit 9db617a into main Sep 30, 2024
27 of 28 checks passed
@bdraco bdraco deleted the stag branch September 30, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError only with versions 2.4.1 and 2.4.2 Vendored _staggered.py causes problems on Python 3.10
1 participant