Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests on 3.8+ #616

Merged
merged 31 commits into from
Nov 10, 2021
Merged

Enable tests on 3.8+ #616

merged 31 commits into from
Nov 10, 2021

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #616 (94d62ae) into master (cc4f6f5) will increase coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   97.05%   97.64%   +0.58%     
==========================================
  Files           6        6              
  Lines         340      340              
  Branches       42       42              
==========================================
+ Hits          330      332       +2     
+ Misses          5        4       -1     
+ Partials        5        4       -1     
Flag Coverage Δ
unit 97.35% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp_session/log.py 100.00% <ø> (ø)
aiohttp_session/__init__.py 98.38% <100.00%> (+1.07%) ⬆️
aiohttp_session/cookie_storage.py 90.32% <100.00%> (ø)
aiohttp_session/memcached_storage.py 97.77% <100.00%> (ø)
aiohttp_session/nacl_storage.py 100.00% <100.00%> (ø)
aiohttp_session/redis_storage.py 97.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f975fbc...94d62ae. Read the comment docs.

@Dreamsorcerer
Copy link
Member Author

@panagiks Not sure if you've got any ideas on this last warning? Seems there is a socket not getting closed, but not sure where. The port number is 6379, which appears to be for the redis server.

@asvetlov
Copy link
Member

asvetlov commented Nov 10, 2021

See aio-libs-abandoned/aioredis-py#1103 for workaround:

         await client.close()
+        await client.connection_pool.disconnect()

tests/conftest.py Outdated Show resolved Hide resolved
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) November 10, 2021 18:35
@Dreamsorcerer Dreamsorcerer merged commit 0735b62 into master Nov 10, 2021
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-2 branch November 10, 2021 18:42
@Dreamsorcerer
Copy link
Member Author

Finally! :P

@asvetlov
Copy link
Member

My congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants