Skip to content

Commit

Permalink
Fix #2547: Drop request.GET (#2548)
Browse files Browse the repository at this point in the history
  • Loading branch information
asvetlov authored Nov 22, 2017
1 parent ed3c7ca commit 20ecc66
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
1 change: 1 addition & 0 deletions CHANGES/2547.removal
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Drop deprecated `request.GET` property.
7 changes: 0 additions & 7 deletions aiohttp/web_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,13 +356,6 @@ def query(self):
"""A multidict with all the variables in the query string."""
return self._rel_url.query

@property
def GET(self):
"""A multidict with all the variables in the query string."""
warnings.warn("GET property is deprecated, use .query instead",
DeprecationWarning)
return self._rel_url.query

@property
def query_string(self):
"""The query string in the URL.
Expand Down
3 changes: 0 additions & 3 deletions tests/test_web_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ def test_ctor():
assert req.raw_headers == ((b'FOO', b'bar'),)
assert req.task is req._task

with pytest.warns(DeprecationWarning):
assert req.GET is req.query


def test_doubleslashes():
# NB: //foo/bar is an absolute URL with foo netloc and /bar path
Expand Down

0 comments on commit 20ecc66

Please sign in to comment.