-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
light version of HttpClient #199
Comments
I think we need http session object for processing keep-alive and cookies updating. Another question: should client/session be constructed on top of connection pool like request library does?
|
what is the reason for keep alive and cookies? we already have both in connector. same for connection pool |
Hm..personally, I didn't found HttpClient useful: it's quite primitive while for mature setups you'll already have some load balancer like haproxy in front of your nodes making HttpClient pool feature not actual. May be it's good to have poorman's client with the connection pool. However, then it should be more featured to not just round robin all the hosts until first success, but pick the best according connection time, load, responsibility and other metrics. What I support is a good topic for new project outside aiohttp domain. As about lightweight http client, I think it should be also more human-friendly: having always to pass request method as a string doesn't make it so.
As about having http session object +1. However, it shouldn't be a hardly embed into the client: http session (cookie, auth headers, whatever) is just a request context which should be switched with easy without creating another HttpClient instance. |
Fixed by introducing |
i removed HttpClient from 0.12, but i think we need some lightweight version of it,
something like
@asvetlov @kxepal @popravich ?
The text was updated successfully, but these errors were encountered: