Failed tests

[socketpair]

parser = <aiohttp.http_parser.HttpRequestParserPy object at 0x7f0f6fcd5240>

    def test_headers_multi_feed(parser):
        text1 = b'GET /test HTTP/1.1\r\n'
        text2 = b'test: line\r'
        text3 = b'\n continue\r\n\r\n'
    
        messages, upgrade, tail = parser.feed_data(text1)
        assert len(messages) == 0
    
        messages, upgrade, tail = parser.feed_data(text2)
        assert len(messages) == 0
    
        messages, upgrade, tail = parser.feed_data(text3)
        assert len(messages) == 1
    
        msg = messages[0][0]
>       assert list(msg.headers.items()) == [('Test', 'line continue')]
E       AssertionError: assert [('test', 'line continue')] == [('Test', 'line continue')]
E         At index 0 diff: ('test', 'line continue') != ('Test', 'line continue')
E         Use -v to get the full diff

python35                                     x86_64                 3.5.3-11495815804.17.829b3b2.ics
python35-async-timeout                       noarch                 1.2.0-11493037590.6.5cb4a94.ics
python35-chardet                             noarch                 2.3.0-11495440004.7.c634272.ics
python35-cython                              x86_64                 0.25.2-11493722904.14.d1eb5b7.ics
python35-multidict                           x86_64                 3.1.1-11501305206.11.46af6c8.ics
python35-pytest                              noarch                 3.1.3-11501482158.8.31a8337.ics
python35-pytest-mock                         noarch                 1.6.2-11501482143.5.a9cd9aa.ics
python35-pytest-raisesregexp                 noarch                 2.1-11501318815.14.a412f9b.ics
python35-setuptools                          noarch                 18.3.1-11496231576.10.6e9c498.ics
python35-yarl                                x86_64                 0.12.0-11501305176.7.cb93a0e.ics
python35-devel                               x86_64                 3.5.3-11495815804.17.829b3b2.ics
python35-py                                  noarch                 1.4.34-11501318840.8.19419e4.ics

[socketpair]

Bug in case sensitivity...but what's wrong? is it safe to turn tests off during CI ?

[socketpair]

seems dup of #2000

[cecton]

Not sure yet what happened and that probably needs investigation. In the meantime, can you try using tox? Pretty sure the problem won't pop up.

[asvetlov]

@socketpair what multidict version do you use?
For aiohttp master it should be 3.0 at least.

[socketpair]

As shown above, I use multidict 3.1.1 with aiohttp 2.2.3. Both are latest releases, but they do not work right together.

[asvetlov]

Have no idea what's going wrong. Tests work locally and on travis: https://travis-ci.org/aio-libs/aiohttp/branches

[socketpair]

I already mentioned #2000. it's changes are NOT MERGED into RELEASED version 2.2.3. But these changes are required to use RELEASED multidict 3.1.1.

(Sorry for caps, they are nothing about cursing, they just mark significant things)

[asvetlov]

Finally got your problem.
The PR was cherry-picked into 2.2 branch.
Is it ok for you?

[socketpair]

Huge thanks. If I understand you right, version 2.2.4 which will be released in a few days will fix my bug.

[asvetlov]

Done

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new