Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdist build gets crashed under pip>=19 in dev mode #3581

Closed
webknjaz opened this issue Jan 28, 2019 · 7 comments · Fixed by #3694
Closed

sdist build gets crashed under pip>=19 in dev mode #3581

webknjaz opened this issue Jan 28, 2019 · 7 comments · Fixed by #3694
Assignees
@webknjaz
Labels
bug infra meta pr-rejected

Comments

@webknjaz
Copy link
Member

webknjaz commented Jan 28, 2019 •
edited
Loading

Long story short

We have cython as an optional dependency. That's why we install it as a pre-requisite in the CI, as a separate step.
New pip creates a separate build virtualenv which doesn't have access to the place with cython installed which causes it to crash.

Expected behaviour

It succeeds

Actual behaviour

It tracebacks

Steps to reproduce

Your environment

Travis CI (doesn't really matter actually)
@webknjaz webknjaz self-assigned this Jan 28, 2019
@aio-libs-bot

This comment has been minimized.

Sign in to view
webknjaz added a commit that referenced this issue Jan 28, 2019
@webknjaz
🚑 Use pip<19 in CI to mitigate a build failure
9e23cf8 
Prior to this change, CIs were failing during build step as well
as any other attempts to install aiohttp from sdist (tarball).

This change creates a temporary workaround for #3581 and should be
reverted once the proper solution is found and implemented.
@webknjaz
Copy link
Member Author

Temporary workaround: 9e23cf8.

@asvetlov I strongly recommend not doing any releases until this is addressed properly. I didn't add a change note because I hope that it'll be reverted by the time of release.

@webknjaz
Copy link
Member Author

pip install -U 'pip<19' doesn't work for some reason under Windows: https://ci.appveyor.com/project/aio-libs/aiohttp/build/job/26xnep0pwnpb8ttk#L9. But that workaround at least fixed Travis CI so it's usable now.

@webknjaz
Copy link
Member Author

pip install -U 'pip<19' doesn't work for some reason under Windows:

Addressed with d5d5d16

@kxepal kxepal mentioned this issue Jan 29, 2019
Closed
@webknjaz
Copy link
Member Author

@pradyunsg could you please link the upstream issue here?

@pradyunsg
Copy link

Yeps! pypa/pip#6144

@asvetlov asvetlov mentioned this issue Jan 30, 2019
Closed
@webknjaz webknjaz mentioned this issue Jan 31, 2019
Closed
5 tasks
@webknjaz
Copy link
Member Author

FTR. Solution PoC: #3589

@webknjaz webknjaz changed the title sdist build gets crashed under pip>=19 sdist build gets crashed under pip>=19 in dev mode Feb 12, 2019
@webknjaz webknjaz mentioned this issue Feb 12, 2019
Closed
@webknjaz webknjaz mentioned this issue Mar 29, 2019
Merged
This was referenced Apr 15, 2019
Closed
Merged
@webknjaz webknjaz mentioned this issue Apr 19, 2019
Closed
@helpr helpr bot added the pr-rejected label Jul 19, 2019
@webknjaz webknjaz mentioned this issue Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webknjaz webknjaz

Labels
bug infra meta pr-rejected
Projects
None yet
Milestone
No milestone
3 participants
@webknjaz @pradyunsg @aio-libs-bot