Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow request body copy #2126

Merged
merged 10 commits into from
Nov 24, 2017
Merged

Slow request body copy #2126

merged 10 commits into from
Nov 24, 2017

Commits on Nov 24, 2017

  1. avoid copying the request payload before writing it to the transport

    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    6f6b466 View commit details
    Browse the repository at this point in the history

  2. when the server closes the connection before writing EOF, the client … 

    …should see a payload error, not expect to see the deconnection before the body is read
    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    33d74e0 View commit details
    Browse the repository at this point in the history

  3. do not use private attributes in SendfilePayloadWriter

    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    691caf4 View commit details
    Browse the repository at this point in the history

  4. on windows, some test is now raising a fully fledged ClientOSError in… 

    …stead of an empty ServerDisconnectedError
    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    7860d10 View commit details
    Browse the repository at this point in the history

  5. code review

    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    2c5d10a View commit details
    Browse the repository at this point in the history

  6. add CHANGES file

    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    20bf8fa View commit details
    Browse the repository at this point in the history

  7. in PayloadWriter, the waiter result is set and the self._drain_waiter… 

    … is set back to None at the same time. So self._drain_waiter can never be done()
    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    7e1768f View commit details
    Browse the repository at this point in the history

  8. test compressing by chunks in the PayloadWriter (cover the branch whe… 

    …re a chunk does not yield anything that should be written to the transport)
    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    a42d2cf View commit details
    Browse the repository at this point in the history

  9. Test writing too many chunks to a PayloadWriter that has a Content-Le… 

    …ngth
    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    0c6c30e View commit details
    Browse the repository at this point in the history

  10. test multiple waiting drains in PayloadWriter

    @arthurdarcet
    arthurdarcet committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    a4c52fb View commit details
    Browse the repository at this point in the history