Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for python version in parallel to environment marker #2813

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Add a check for python version in parallel to environment marker #2813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d562f58
Add a check for python version in parallel to environment marker
asvetlov Mar 7, 2018
866ea25
Update CHANGES
asvetlov Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES/2813.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Restore a imperative check in ``setup.py`` for python version. The
check works in parallel to environment marker. As effect a error about
unsupported Python versions is raised even on outdated systems with
very old ``setuptools`` version installed.
4 changes: 4 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
from setuptools.command.test import test as TestCommand


if sys.version_info < (3, 5, 3):
raise RuntimeError("aiohttp 3.x requires Python 3.5.3+")


try:
from Cython.Build import cythonize
USE_CYTHON = True
Expand Down