Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI archive does not contain vendor/http-parser/http_parser.h #3076

Closed
moubctez opened this issue Jun 12, 2018 · 2 comments
Closed

PyPI archive does not contain vendor/http-parser/http_parser.h #3076

moubctez opened this issue Jun 12, 2018 · 2 comments
Labels

Comments

@moubctez
Copy link

Long story short

The archive distributed on PyPI.org does not contain vendor/http-parser/http_parser.h, so compilation fails with:

aiohttp/_http_parser.c:589:10: fatal error: '../vendor/http-parser/http_parser.h' file not found

Expected behaviour

aiohttp package on PyPI.org contains vendor/http-parser/http_parser.h

Actual behaviour

The file is missing, but required by `vendor/http-parser/http_parser.c:

#include "http_parser.h"

Steps to reproduce

Download aiohttp-3.3.1.tar.gz from https://pypi.org/project/aiohttp/#files and build.

@asvetlov
Copy link
Member

Thank you for the report

kornicameister referenced this issue in kornicameister/korni-stats-collector Jun 12, 2018
This PR updates [aiohttp](https://pypi.org/project/aiohttp) from **3.3.1** to **3.3.2**.



<details>
  <summary>Changelog</summary>
  
  
   ### 3.3.2
   ```
   ==================

- Many HTTP proxies has buggy keepalive support. Let&#39;s not reuse connection but
  close it after processing every response. (`3070 &lt;https://github.com/aio-libs/aiohttp/pull/3070&gt;`_)

- Provide vendor source files in tarball (`3076 &lt;https://github.com/aio-libs/aiohttp/pull/3076&gt;`_)
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/aiohttp
  - Changelog: https://pyup.io/changelogs/aiohttp/
  - Repo: https://github.com/aio-libs/aiohttp
</details>
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants