RTD is still showing docs for 3.3 #3221

hynek · 2018-08-27T13:16:13Z

https://aiohttp.readthedocs.io/ is currently showing the docs for “Current version is 3.3.2.”

webknjaz · 2018-08-27T13:34:14Z

Apparently, this is failing because of #3189: https://readthedocs.org/projects/aiohttp/builds/

webknjaz · 2018-08-27T13:37:22Z

Probably adding requirements_file: requirements/cython.txt to .readthedocs.yml will fix docs build.

asvetlov · 2018-08-27T20:49:00Z

Hrr.

Looks like readthedocs ignores Install your project inside a virtualenv using setup.py install option
Technically docs build doesn't need aiohttp installed but this mode is not supported by rtfd.

Will fix it. Thanks for pointing on readthedocs yaml config.

webknjaz · 2018-08-28T09:18:54Z

No, it doesn't ignore that, it just has different defaults. Are you referring to the yaml config?

Fixes #3221 Ref: https://docs.rtfd.io/en/latest/yaml-config.html

webknjaz · 2018-08-28T11:39:34Z

Fixed by disabling pip install . in RTD: https://readthedocs.org/projects/aiohttp/builds/7699754/

webknjaz · 2018-08-28T11:40:37Z

Probably needs to be backported to 3.4

Fixes #3221 Ref: https://docs.rtfd.io/en/latest/yaml-config.html

webknjaz · 2018-08-28T11:45:17Z

@asvetlov backported, but it didn't trigger the build for stable in RTD. Any settings missing?

webknjaz · 2018-08-28T11:54:35Z

@asvetlov this probably needs another version pushed: https://docs.readthedocs.io/en/latest/versions.html
maybe 3.4.0.post0?

asvetlov · 2018-08-28T12:53:54Z

Thank you.
I'll publish 3.4.1

asvetlov · 2018-08-28T12:55:07Z

I did try to disable pip install . by RTD web interface without success.
Config file is obviously much better option

webknjaz · 2018-08-28T13:33:00Z

I guess the config's priority is higher (probably)

This PR updates [aiohttp](https://pypi.org/project/aiohttp) from **3.3.2** to **3.4.4**. <details> <summary>Changelog</summary> ### 3.4.4 ``` ================== - Fix installation from sources when compiling toolkit is not available (`3241 <https://github.com/aio-libs/aiohttp/pull/3241>`_) ``` ### 3.4.3 ``` ================== - Add ``app.pre_frozen`` state to properly handle startup signals in sub-applications. (`3237 <https://github.com/aio-libs/aiohttp/pull/3237>`_) ``` ### 3.4.2 ``` ================== - Fix ``iter_chunks`` type annotation (`3230 <https://github.com/aio-libs/aiohttp/pull/3230>`_) ``` ### 3.4.1 ``` ================== - Fix empty header parsing regression. (`3218 <https://github.com/aio-libs/aiohttp/pull/3218>`_) - Fix BaseRequest.raw_headers doc. (`3215 <https://github.com/aio-libs/aiohttp/pull/3215>`_) - Fix documentation building on ReadTheDocs (`3221 <https://github.com/aio-libs/aiohttp/pull/3221>`_) ``` ### 3.4.0 ``` ================== Features -------- - Add type hints (`3049 <https://github.com/aio-libs/aiohttp/pull/3049>`_) - Add ``raise_for_status`` request parameter (`3073 <https://github.com/aio-libs/aiohttp/pull/3073>`_) - Add type hints to HTTP client (`3092 <https://github.com/aio-libs/aiohttp/pull/3092>`_) - Minor server optimizations (`3095 <https://github.com/aio-libs/aiohttp/pull/3095>`_) - Preserve the cause when `HTTPException` is raised from another exception. (`3096 <https://github.com/aio-libs/aiohttp/pull/3096>`_) - Add `close_boundary` option in `MultipartWriter.write` method. Support streaming (`3104 <https://github.com/aio-libs/aiohttp/pull/3104>`_) - Added a ``remove_slash`` option to the ``normalize_path_middleware`` factory. (`3173 <https://github.com/aio-libs/aiohttp/pull/3173>`_) - The class `AbstractRouteDef` is importable from `aiohttp.web`. (`3183 <https://github.com/aio-libs/aiohttp/pull/3183>`_) Bugfixes -------- - Prevent double closing when client connection is released before the last ``data_received()`` callback. (`3031 <https://github.com/aio-libs/aiohttp/pull/3031>`_) - Make redirect with `normalize_path_middleware` work when using url encoded paths. (`3051 <https://github.com/aio-libs/aiohttp/pull/3051>`_) - Postpone web task creation to connection establishment. (`3052 <https://github.com/aio-libs/aiohttp/pull/3052>`_) - Fix ``sock_read`` timeout. (`3053 <https://github.com/aio-libs/aiohttp/pull/3053>`_) - When using a server-request body as the `data=` argument of a client request, iterate over the content with `readany` instead of `readline` to avoid `Line too long` errors. (`3054 <https://github.com/aio-libs/aiohttp/pull/3054>`_) - fix `UrlDispatcher` has no attribute `add_options`, add `web.options` (`3062 <https://github.com/aio-libs/aiohttp/pull/3062>`_) - correct filename in content-disposition with multipart body (`3064 <https://github.com/aio-libs/aiohttp/pull/3064>`_) - Many HTTP proxies has buggy keepalive support. Let's not reuse connection but close it after processing every response. (`3070 <https://github.com/aio-libs/aiohttp/pull/3070>`_) - raise 413 "Payload Too Large" rather than raising ValueError in request.post() Add helpful debug message to 413 responses (`3087 <https://github.com/aio-libs/aiohttp/pull/3087>`_) - Fix `StreamResponse` equality, now that they are `MutableMapping` objects. (`3100 <https://github.com/aio-libs/aiohttp/pull/3100>`_) - Fix server request objects comparison (`3116 <https://github.com/aio-libs/aiohttp/pull/3116>`_) - Do not hang on `206 Partial Content` response with `Content-Encoding: gzip` (`3123 <https://github.com/aio-libs/aiohttp/pull/3123>`_) - Fix timeout precondition checkers (`3145 <https://github.com/aio-libs/aiohttp/pull/3145>`_) Improved Documentation ---------------------- - Add a new FAQ entry that clarifies that you should not reuse response objects in middleware functions. (`3020 <https://github.com/aio-libs/aiohttp/pull/3020>`_) - Add FAQ section "Why is creating a ClientSession outside of an event loop dangerous?" (`3072 <https://github.com/aio-libs/aiohttp/pull/3072>`_) - Fix link to Rambler (`3115 <https://github.com/aio-libs/aiohttp/pull/3115>`_) - Fix TCPSite documentation on the Server Reference page. (`3146 <https://github.com/aio-libs/aiohttp/pull/3146>`_) - Fix documentation build configuration file for Windows. (`3147 <https://github.com/aio-libs/aiohttp/pull/3147>`_) - Remove no longer existing lingering_timeout parameter of Application.make_handler from documentation. (`3151 <https://github.com/aio-libs/aiohttp/pull/3151>`_) - Mention that ``app.make_handler`` is deprecated, recommend to use runners API instead. (`3157 <https://github.com/aio-libs/aiohttp/pull/3157>`_) Deprecations and Removals ------------------------- - Drop ``loop.current_task()`` from ``helpers.current_task()`` (`2826 <https://github.com/aio-libs/aiohttp/pull/2826>`_) - Drop ``reader`` parameter from ``request.multipart()``. (`3090 <https://github.com/aio-libs/aiohttp/pull/3090>`_) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/aiohttp - Changelog: https://pyup.io/changelogs/aiohttp/ - Repo: https://github.com/aio-libs/aiohttp </details>

lock · 2019-10-28T01:02:54Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

webknjaz added bug documentation Improvements or additions to documentation infra labels Aug 27, 2018

webknjaz added the need pull request label Aug 27, 2018

webknjaz assigned asvetlov and webknjaz Aug 27, 2018

webknjaz added a commit that referenced this issue Aug 28, 2018

Install requirements in RTD

6763729

Fixes #3221 Ref: https://docs.rtfd.io/en/latest/yaml-config.html

webknjaz mentioned this issue Aug 28, 2018

Install requirements in RTD #3224

Merged

webknjaz closed this as completed in #3224 Aug 28, 2018

webknjaz added a commit that referenced this issue Aug 28, 2018

Install requirements in RTD (#3224)

1325fd9

Fixes #3221 Ref: https://docs.rtfd.io/en/latest/yaml-config.html

webknjaz mentioned this issue Aug 28, 2018

Disable installing RTD deps #3225

Merged

webknjaz added a commit that referenced this issue Aug 28, 2018

Install requirements in RTD (#3224)

e426f8c

Fixes #3221 Ref: https://docs.rtfd.io/en/latest/yaml-config.html

webknjaz added a commit that referenced this issue Aug 28, 2018

Disable installing deps in RTD

df90e62

Fixes #3221 Ref: https://docs.rtfd.io/en/latest/yaml-config.html

webknjaz mentioned this issue Aug 28, 2018

Disable installing deps in RTD #3226

Merged

webknjaz added a commit that referenced this issue Aug 28, 2018

Disable installing deps in RTD (#3226)

f76444c

Fixes #3221 Ref: https://docs.rtfd.io/en/latest/yaml-config.html

dependencies bot mentioned this issue Aug 29, 2018

aiohttp versions available: 3.4.1 Harmon758/Harmonbot#305

Closed

lock bot added the outdated label Oct 28, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RTD is still showing docs for 3.3 #3221

RTD is still showing docs for 3.3 #3221

hynek commented Aug 27, 2018

webknjaz commented Aug 27, 2018

webknjaz commented Aug 27, 2018 •

edited

Loading

asvetlov commented Aug 27, 2018

webknjaz commented Aug 28, 2018

webknjaz commented Aug 28, 2018

webknjaz commented Aug 28, 2018

webknjaz commented Aug 28, 2018

webknjaz commented Aug 28, 2018

asvetlov commented Aug 28, 2018

asvetlov commented Aug 28, 2018

webknjaz commented Aug 28, 2018

lock bot commented Oct 28, 2019

RTD is still showing docs for 3.3 #3221

RTD is still showing docs for 3.3 #3221

Comments

hynek commented Aug 27, 2018

webknjaz commented Aug 27, 2018

webknjaz commented Aug 27, 2018 • edited Loading

asvetlov commented Aug 27, 2018

webknjaz commented Aug 28, 2018

webknjaz commented Aug 28, 2018

webknjaz commented Aug 28, 2018

webknjaz commented Aug 28, 2018

webknjaz commented Aug 28, 2018

asvetlov commented Aug 28, 2018

asvetlov commented Aug 28, 2018

webknjaz commented Aug 28, 2018

lock bot commented Oct 28, 2019

webknjaz commented Aug 27, 2018 •

edited

Loading