Setup pre-commit hooks configuration #5136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
added a commit
that referenced
this pull request
Oct 25, 2020
asvetlov
added a commit
that referenced
this pull request
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started by applying https://github.com/asottile/pyupgrade tool but found that we can get benefits from other hooks as well.
I don't clean up the linter step on CI. For now, let's apply the PR and drop duplicated checks later.
Also, I did not apply pyupgrade converter results to the PR because I want to backport configuration to 3.7/3.8 branches first and apply fixers in separate commits.