Add Happy Eyeballs support to TCPConnector #5471
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
They add Happy Eyeballs support to
TCPConnector
and enable it by default.Are there changes in behavior for the user?
aiohttp should become more responsive to users having dual-stack configuration.
For example, Go enabled Happy Eyeballs (Fast Fallback) by default in 2018 golang/go@efc1850.
Also, in #4446 (comment) @asvetlov wrote that Happy Eyeballs may help with enabling aiodns by default. But I would not do so for now because pycares that is a dependency of aiodns uses an old version of c-ares that has security vulnerabilities.
Related issue number
Closes #4451
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.