-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate autobahn tests with pytest #5809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5809 +/- ##
===========================================
+ Coverage 0 93.30% +93.30%
===========================================
Files 0 102 +102
Lines 0 30048 +30048
Branches 0 1916 +1916
===========================================
+ Hits 0 28035 +28035
- Misses 0 1835 +1835
- Partials 0 178 +178
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@webknjaz Here's a quick update:
|
@anesabml for now, just run this under Linux jobs (use |
@webknjaz is there anything I should add to this PR? |
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@webknjaz is there anything I should add to this PR to close it? |
Sorry I haven't had time to review this sooner. I suppose it's good enough, no need to iterate on improvements forever. Those could be added separately when needed. |
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply a45c7c5 on top of patchback/backports/3.8/a45c7c53e20ccf77f4f6b721157d4a449c0f1208/pr-5809 Backporting merged PR #5809 into master
🤖 @patchback |
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
@anesabml mind backporting? |
@webknjaz sure, I will backport it |
Wonderful, thanks! |
Here's the PR #6074 |
* Integrate autobahn tests with pytest * Fix docker compose file paths * Fix typo in CHANGES file * Fix add python-on-whales dependency to .in file instead of .txt * Use pathlib instead of os * Use buildx instead of compose build * Regenerate dev requirements * Rename changes file * Use request fspath instead of hard coded path * Create a sepearte builder when building aiohttp * Use subprocess instead of python-on-whales * Extract failed tests and make assertions on them * Fix lint issues * Fix fixture scope * Add ports to docker-compose files * Add wait-for-it package * Use xfail instead of fail * Use wstest cmd tool instead of the docker image * Fix lint issues * Use assert statement with custom output Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> * Code cleanup * Use docker instead of docker-compose * Add xfail decorator * Add tmp_path * Remove gitignore * Skip tests only on macOS * Check if docker is available * Regenerate dev.txt Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> (cherry picked from commit a45c7c5)
What do these changes do?
Automate running autobahn test suite.
Are there changes in behavior for the user?
No.
Related issue number
#4247
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.