Add socket factory to BaseTestServer

[derlih]

What do these changes do?

Add a socket factory to BaseTestServer. It enables using custom sockets in tests.

Are there changes in behavior for the user?

No

Related issue number

#5844

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[codecov]

Codecov Report

Merging #5845 (cc692ca) into master (9a1c862) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head cc692ca differs from pull request most recent head 3f9ff48. Consider uploading reports for the commit 3f9ff48 to get more accurate results

@@           Coverage Diff           @@
##           master    #5845   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         102      102           
  Lines       30218    30230   +12     
  Branches     2710     2711    +1     
=======================================
+ Hits        28192    28204   +12     
  Misses       1849     1849           
  Partials      177      177           

Flag	Coverage Δ
unit	93.22% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiohttp/test_utils.py	99.06% <100.00%> (+<0.01%)	⬆️
tests/test_test_utils.py	98.29% <100.00%> (+0.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1c862...3f9ff48. Read the comment docs.

[bmerry]

Is this functionality accessible from the aiohttp_client pytest fixture?

[derlih]

Is this functionality accessible from the aiohttp_client pytest fixture?

Yes.
There is a server_kwargs parameter of aiohttp_client fixture that are passed to the TestServer.

aiohttp/aiohttp/pytest_plugin.py

Lines 332 to 353 in d55728d

	@pytest.fixture
	def aiohttp_client(
	loop: asyncio.AbstractEventLoop, aiohttp_client_cls: Type[TestClient]
	) -> Generator[AiohttpClient, None, None]:
	"""Factory to create a TestClient instance.
	aiohttp_client(app, **kwargs)
	aiohttp_client(server, **kwargs)
	aiohttp_client(raw_server, **kwargs)
	"""
	clients = []
	async def go(
	__param: Union[Application, BaseTestServer],
	*,
	server_kwargs: Optional[Dict[str, Any]] = None,
	**kwargs: Any
	) -> TestClient:
	if isinstance(__param, Application):
	server_kwargs = server_kwargs or {}
	server = TestServer(__param, **server_kwargs)
	client = aiohttp_client_cls(server, **kwargs)

[asvetlov]

LGTM
Please feel free to merge.
Backporting is up to you (but recommended).
The simplest backport strategy is adding 3.8 label before merging, a bot should do the rest.
Sometimes the backporting requires manual intervention, the bot adds a comment with instructions in this case.

[webknjaz]

Approved but plz rebase before merging to pull in the most recent CI changes.

[patchback]

Backport to 3.8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 573916f on top of patchback/backports/3.8/573916f0ebea517bdb6b162bcf74078acb0dfaf9/pr-5845

Backporting merged PR #5845 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.8/573916f0ebea517bdb6b162bcf74078acb0dfaf9/pr-5845 upstream/3.8

4. Now, cherry-pick PR Add socket factory to BaseTestServer #5845 contents into that branch:

   $ git cherry-pick -x 573916f0ebea517bdb6b162bcf74078acb0dfaf9

   If it'll yell at you with something like fatal: Commit 573916f0ebea517bdb6b162bcf74078acb0dfaf9 is a merge but no -m option was given., add -m 1 as follows intead:

   $ git cherry-pick -m1 -x 573916f0ebea517bdb6b162bcf74078acb0dfaf9

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Add socket factory to BaseTestServer #5845 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.8/573916f0ebea517bdb6b162bcf74078acb0dfaf9/pr-5845

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[aio-libs-github-bot]

💔 Backport was not successful

The PR was attempted backported to the following branches:

• ❌ 3.8: Commit could not be cherrypicked due to conflicts

[asvetlov]

Failure. @derlih would you backport it manually?