Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add charset parameter to web.Response constructor #593

Closed
asvetlov opened this issue Oct 26, 2015 · 4 comments
Closed

Add charset parameter to web.Response constructor #593

asvetlov opened this issue Oct 26, 2015 · 4 comments
Labels
good first issue Good for newcomers outdated
Milestone
0.19

Comments

@asvetlov
Copy link
Member

Existing content_type param is for type only, e.g. text/html or application/json.
Charset utf-8 is added ultimately and text is encoded as utf-8.

We need add charset param to constructor (urf-8 by default) and respect the param on text encoding.

Check for content_type should be added also to forbid ; (mark for charset) in the value.

The patch is trivial but should be proposed with tests.

Any volunteers for making Pull Request?
@asvetlov asvetlov added the good first issue Good for newcomers label Oct 26, 2015
@asvetlov asvetlov added this to the 0.19 milestone Oct 26, 2015
@asvetlov
Copy link
Member Author

See also aio-libs/aiohttp-debugtoolbar#28

@jashandeep-sohi
Copy link
Contributor

I have some free time this week. I'll take a crack at it.

jashandeep-sohi added a commit to jashandeep-sohi/aiohttp that referenced this issue Oct 26, 2015
@jashandeep-sohi
Add charset parameter to web.Response constructor. aio-libs#593
4dc43e8
@jashandeep-sohi jashandeep-sohi mentioned this issue Oct 26, 2015
Merged
@asvetlov
Copy link
Member Author

Fixed. Thanks, @jashandeep-sohi

@aio-libs-bot aio-libs-bot mentioned this issue Nov 8, 2018
Closed
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers outdated
Projects
None yet
Milestone
0.19
Development

No branches or pull requests
2 participants
@asvetlov @jashandeep-sohi