Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Read The Docs config #7272

Merged
merged 3 commits into from
May 7, 2023
Merged

Fix Read The Docs config #7272

merged 3 commits into from
May 7, 2023

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.9 labels May 7, 2023
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) May 7, 2023 22:10
@codecov
Copy link

codecov bot commented May 7, 2023 •
edited
Loading

Codecov Report

Merging #7272 (4c8ca88) into master (2be9318) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7272   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         107      107           
  Lines       31485    31485           
  Branches     3937     3937           
=======================================
  Hits        30640    30640           
  Misses        641      641           
  Partials      204      204
Flag Coverage Δ
CI-GHA 97.22% <ø> (ø)
OS-Linux 96.87% <ø> (-0.01%) ⬇️
OS-Windows 95.30% <ø> (ø)
OS-macOS 96.46% <ø> (ø)
Py-3.10.11 96.98% <ø> (ø)
Py-3.11.0 96.41% <ø> (ø)
Py-3.7.16 96.70% <ø> (ø)
Py-3.7.9 95.17% <ø> (ø)
Py-3.8.10 95.09% <ø> (ø)
Py-3.8.16 96.61% <ø> (ø)
Py-3.9.13 95.08% <ø> (ø)
Py-3.9.16 96.63% <ø> (ø)
Py-pypy7.3.11 94.12% <ø> (-0.01%) ⬇️
VM-macos 96.46% <ø> (ø)
VM-ubuntu 96.87% <ø> (-0.01%) ⬇️
VM-windows 95.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz
Copy link
Member

webknjaz commented May 7, 2023

What was broken?

@Dreamsorcerer
Copy link
Member Author

Wrong version of ssl. Seems it needs the OS set explicitly to the latest version (maybe that build: latest is a setting that has been removed?).

@webknjaz
Copy link
Member

webknjaz commented May 7, 2023

Oh, that's because urllib3 v2 is finally out (and unpinned!)
Fair enough..

@Dreamsorcerer Dreamsorcerer merged commit b2a7983 into master May 7, 2023
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch May 7, 2023 23:04
@patchback
Copy link
Contributor

patchback bot commented May 7, 2023 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/b2a7983aed047e36c3418e788096d7f46cea7e1e/pr-7272

Backported as #7273

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 7, 2023
@Dreamsorcerer @patchback
Fix Read The Docs config (#7272)
334e837 
(cherry picked from commit b2a7983)
@patchback patchback bot mentioned this pull request May 7, 2023
Merged
@Dreamsorcerer
Copy link
Member Author

Also, did you disable the admin bypass for branch protection recently? I wouldn't care, but the CI currently always waits 30 mins for the Windows test to timeout and fail before it merges things..

@webknjaz
Copy link
Member

webknjaz commented May 7, 2023

I think I did at some point. OTOH, you shouldn't have to babysit the CI if you use automerge. If the windows jobs time out and you know what a typical success timeline looks like, I'd recommend setting that timeout for said jobs to improve responsiveness..

Dreamsorcerer added a commit that referenced this pull request May 7, 2023
@patchback @Dreamsorcerer
[PR #7272/b2a7983a backport][3.9] Fix Read The Docs config (#7273)
bddf6c2 
**This is a backport of PR #7272 as merged into master
(b2a7983).**

None

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
@Dreamsorcerer
Copy link
Member Author

It's just the 3.11 broken one. While the Mac one fails quickly, the Windows one has a test which takes 5 mins to timeout (and then retries that failed test).

@patchback
Copy link
Contributor

patchback bot commented Oct 3, 2023 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/b2a7983aed047e36c3418e788096d7f46cea7e1e/pr-7272

Backported as #7650

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 3, 2023
@Dreamsorcerer @patchback
Fix Read The Docs config (#7272)
2a72c9f 
(cherry picked from commit b2a7983)
@patchback patchback bot mentioned this pull request Oct 3, 2023
Merged
Dreamsorcerer added a commit that referenced this pull request Oct 3, 2023
@patchback @Dreamsorcerer
[PR #7272/b2a7983a backport][3.8] Fix Read The Docs config (#7650)
8a3977a 
**This is a backport of PR #7272 as merged into master
(b2a7983).**

None

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dreamsorcerer @webknjaz