Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with connection upgrade (#7879) #7907

Conversation

Dreamsorcerer
Copy link
Member

Fixes #7867.

(cherry picked from commit 48b1558)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 26, 2023
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) November 26, 2023 14:41
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31d0834) 97.16% compared to head (6db183c) 97.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #7907      +/-   ##
==========================================
+ Coverage   97.16%   97.35%   +0.19%     
==========================================
  Files         108      108              
  Lines       32443    32459      +16     
  Branches     3133     3849     +716     
==========================================
+ Hits        31522    31600      +78     
+ Misses        702      655      -47     
+ Partials      219      204      -15     
Flag Coverage Δ
CI-GHA 97.26% <100.00%> (+0.15%) ⬆️
OS-Linux 96.95% <100.00%> (+0.16%) ⬆️
OS-Windows 94.45% <100.00%> (-0.01%) ⬇️
OS-macOS 96.76% <100.00%> (+0.19%) ⬆️
Py-3.10.11 94.35% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.73% <100.00%> (+<0.01%) ⬆️
Py-3.11.6 96.49% <100.00%> (?)
Py-3.8.10 94.33% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.66% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.34% <100.00%> (-0.01%) ⬇️
Py-3.9.18 96.71% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.13 96.17% <100.00%> (?)
VM-macos 96.76% <100.00%> (+0.19%) ⬆️
VM-ubuntu 96.95% <100.00%> (+0.16%) ⬆️
VM-windows 94.45% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 566f346 into 3.10 Nov 26, 2023
25 of 29 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.10/48b15583305e692ce997ec6f5a6a2f88f23ace71/pr-7879 branch November 26, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant