-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples of fallback_charset_resolver
function in client_advanced documentation
#7995
Conversation
fallback_charset_resolver
function in client_advanced documentationfallback_charset_resolver
function in client_advanced documentation
fallback_charset_resolver
function in client_advanced documentationfallback_charset_resolver
function in client_advanced documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7995 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 107 107
Lines 32551 32551
Branches 3793 3793
=======================================
Hits 31725 31725
Misses 624 624
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8044 🤖 @patchback |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8045 🤖 @patchback |
What do these changes do?
This PR improves the
client_advanced.rst
documentation in the aiohttp project. It corrects the syntax in thefallback_charset_resolver
function example. Specifically, it changes a miswritten 'lamba' to 'lambda' and adds.encode()
to thetld
parameter in thedetect
function call, ensuring proper byte format.Are there changes in behavior for the user?
No changes in behavior for the end users are introduced. This PR solely improves the documentation for better clarity and correctness in the examples provided.
Related issue number
There's no specific related issue number for this PR. This is a direct improvement to the documentation based on observed inconsistencies.
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.