Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of starting request handlers with Python 3.12+ #8661

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Improve performance of starting request handlers with Python 3.12+ #8661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a892e91
Improve performance of starting request handlers with Python 3.12+
bdraco Aug 8, 2024
3482ab3
Improve performance of starting request handlers with Python 3.12+
bdraco Aug 8, 2024
a4a0dd3
changelog
bdraco Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/8661.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improved performance of starting request handlers with Python 3.12+ -- by :user:`bdraco`.
9 changes: 6 additions & 3 deletions aiohttp/web_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import asyncio
import asyncio.streams
import dataclasses
import sys
import traceback
from collections import deque
from contextlib import suppress
Expand Down Expand Up @@ -543,9 +544,11 @@ async def start(self) -> None:
request = self._request_factory(message, payload, self, writer, handler)
try:
# a new task is used for copy context vars (#3406)
task = self._loop.create_task(
self._handle_request(request, start, request_handler)
)
coro = self._handle_request(request, start, request_handler)
if sys.version_info >= (3, 12):
task = asyncio.Task(coro, loop=loop, eager_start=True)
Dismissed Show dismissed Hide dismissed
else:
task = loop.create_task(coro)
try:
resp, reset = await task
except (asyncio.CancelledError, ConnectionError):
Expand Down
Loading