Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8736/1b88af2 backport][3.10] Improve performance of WebSocketReader #8743

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 19, 2024

(cherry picked from commit 1b88af2)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 19, 2024
@bdraco bdraco changed the title Improve performance of WebSocketReader (#8736) [PR #8736/1b88af2 backport][3.10] Improve performance of WebSocketReader Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (dba2605) to head (b5ba2c7).
Report is 1 commits behind head on 3.10.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8743   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files         108      108           
  Lines       34164    34167    +3     
  Branches     4063     4064    +1     
=======================================
+ Hits        33378    33381    +3     
  Misses        587      587           
  Partials      199      199           
Flag Coverage Δ
CI-GHA 97.59% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.27% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.79% <98.07%> (-0.01%) ⬇️
OS-macOS 96.93% <98.07%> (+<0.01%) ⬆️
Py-3.10.11 97.02% <98.07%> (-0.01%) ⬇️
Py-3.10.14 96.97% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.21% <100.00%> (+0.09%) ⬆️
Py-3.12.4 97.30% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.43% <94.23%> (-0.02%) ⬇️
Py-3.8.18 96.78% <96.15%> (-0.01%) ⬇️
Py-3.9.13 96.92% <94.23%> (-0.02%) ⬇️
Py-3.9.19 96.88% <96.15%> (-0.01%) ⬇️
Py-pypy7.3.16 96.47% <96.15%> (-0.01%) ⬇️
VM-macos 96.93% <98.07%> (+<0.01%) ⬆️
VM-ubuntu 97.27% <100.00%> (+<0.01%) ⬆️
VM-windows 94.79% <98.07%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 19, 2024 17:11
@bdraco bdraco enabled auto-merge (squash) August 19, 2024 17:11
@bdraco bdraco merged commit fbfedd6 into 3.10 Aug 19, 2024
31 of 32 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/1b88af2c3f5e5f992d0015f90927fd9c3e00bef0/pr-8736 branch August 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant