-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace code that can now be handled by yarl #9301
Conversation
- The manual join of the query string in ClientRequest.send can be replaced with url.raw_path_qs - All the IPv6 bracket checks can be replaced with url.host_subcomponent with yarl 1.13.0+
I'm almost tempted to bump minimum yarl again so we don't have maintain the branching here |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #9301 +/- ##
==========================================
- Coverage 98.55% 98.50% -0.05%
==========================================
Files 107 107
Lines 34867 34876 +9
Branches 4134 4139 +5
==========================================
- Hits 34364 34356 -8
- Misses 335 352 +17
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Just bump it in 3.11 and the branching can sit in the 3.10 release for a short while. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c240b52 on top of patchback/backports/3.10/c240b52de0505759aa13f2870feb7380d3b50a56/pr-9301 Backporting merged PR #9301 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c240b52 on top of patchback/backports/3.11/c240b52de0505759aa13f2870feb7380d3b50a56/pr-9301 Backporting merged PR #9301 into master
🤖 @patchback |
(cherry picked from commit c240b52)
(cherry picked from commit c240b52)
Needs yarl bumped to 1.13.0+
What do these changes do?
The manual join of the query string in ClientRequest.send can be replaced with url.raw_path_qs
All the IPv6 bracket checks can be replaced with url.host_subcomponent with yarl 1.13.0+
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no