-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __slots__ to stream classes #9407
Conversation
We use `__slots__` almost everywhere else in the codebase, however `__slots__` were not implemented in stream related issue #4618
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9407 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 107 107
Lines 35037 35043 +6
Branches 4150 4150
=======================================
+ Hits 34536 34542 +6
Misses 334 334
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Probably should not backport to 3.10 just in case someone is doing some interesting subclassing |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9408 🤖 @patchback |
(cherry picked from commit e653b28)
What do these changes do?
We use
__slots__
almost everywhere else in the codebase, however__slots__
were not implemented in streamrelated issue #4618 (comment)
Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no