Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typing to aiokafka/record/* #1001

Merged
merged 10 commits into from
May 5, 2024

simplify types

0c3200b
Select commit
Loading
Failed to load commit list.
Merged

add typing to aiokafka/record/* #1001

simplify types
0c3200b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 28, 2024 in 0s

95.04% (-0.32%) compared to 1862620

View this Pull Request on Codecov

95.04% (-0.32%) compared to 1862620

Details

Codecov Report

Attention: Patch coverage is 85.47619% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 95.04%. Comparing base (1862620) to head (0c3200b).

Files Patch % Lines
aiokafka/record/_protocols.py 59.71% 0 Missing and 56 partials ⚠️
aiokafka/record/default_records.py 96.66% 2 Missing and 1 partial ⚠️
aiokafka/record/legacy_records.py 97.40% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
- Coverage   95.36%   95.04%   -0.32%     
==========================================
  Files         112      114       +2     
  Lines       16751    16917     +166     
  Branches     2694     2757      +63     
==========================================
+ Hits        15974    16079     +105     
- Misses        489      493       +4     
- Partials      288      345      +57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov