-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change 2 command, use formating literals #404
change 2 command, use formating literals #404
Conversation
Same as the previous one, I'm not convinced this is an improvement when using legacy % string formatting with nested f-string formatting. |
@Dreamsorcerer. About this PR answered in #403. This is apparently a matter of preference code. Even considering that literals themselves are faster than methods and loops, this has absolutely nothing to do with our |
To be honest, we usually use join when we don't know how many arguments need to be converted into a byte string. however, in our case, the rigid argument notation fits very well here. |
After reading this pep, we can only suggest rewriting it with %b since this is a specification for python3. https://peps.python.org/pep-0461/#interpolation |
Yep, just what I said on the other PR, as I saw an update there first. |
Great, then I'll redo the PR. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool)
I try rewrite cmd(s). this optional code maybe easier to read and work.