-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace _val with separate props for url parts #172
Comments
#1396 will get a step closer to this In the future we may want to change the split functions to unpack the values into named variables in future. ie One consideration about getting rid of the It would be a lot nicer if we stored everything in |
This comment was marked as outdated.
This comment was marked as outdated.
Going to leave it open until we get a +/- on performance on #1397 to see if we can move the 2nd attempt forward |
Second attempt in #1397 looks like it will work without regressing performance in a meaningful way |
I was able to squeeze more out of and keep it readable in #1397 |
The target is
URL.build
optimization.The method is crucial for aiohttp web server, avoiding
SplitResult
construction can make the method faster.SplitResult
could be restored in every method that need the object.N.B. Serialization format should support URL classes generated by older library version or the format should not be changed at all (the later looks easier).
The text was updated successfully, but these errors were encountered: