Fix to query_update(None) #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d corresponding test file as well.
psf-chronographer
bot
added
the
bot:chronographer:provided
|
The linter error is not related to your PR. |
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 4 4
Lines 750 752 +2
Branches 208 209 +1
=======================================
+ Hits 748 750 +2
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Any progress on the linter? |
|
I believe the pylint error is due to libenchant-dev no longer being listed in the ubuntu packages. I believe a fix to this would be to change it the github action to "libenchant-2-dev," since that appears to be the replacement, but I don't believe I can run the linter on github to test it. |
1 task
This was referenced Dec 12, 2022
4 tasks
Ferenc-
added a commit
to instana/python-sensor
that referenced
this pull request
May 15, 2023
Apparently the parameter passing in our `aiohttp` tests were incorrect, and was depending on a `yarl` bug [1] that was fixed [2] in `1.9.0`, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latest `yarl`. [1] aio-libs/yarl#723 [2] aio-libs/yarl#792 Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Ferenc-
added a commit
to instana/python-sensor
that referenced
this pull request
May 15, 2023
Apparently the parameter passing in our `aiohttp` tests were incorrect, and was depending on a `yarl` bug [1] that was fixed [2] in `1.9.0`, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latest `yarl`. [1] aio-libs/yarl#723 [2] aio-libs/yarl#792 Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Ferenc-
added a commit
to instana/python-sensor
that referenced
this pull request
May 15, 2023
Apparently the parameter passing in our `aiohttp` tests were incorrect, and was depending on a `yarl` bug [1] that was fixed [2] in `1.9.0`, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latest `yarl`. [1] aio-libs/yarl#723 [2] aio-libs/yarl#792 Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Ferenc-
added a commit
to instana/python-sensor
that referenced
this pull request
May 15, 2023
Apparently the parameter passing in our `aiohttp` tests were incorrect, and was depending on a `yarl` bug [1] that was fixed [2] in `1.9.0`, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latest `yarl`. [1] aio-libs/yarl#723 [2] aio-libs/yarl#792 Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the query_update() function special case where the None argument should clear query.
The query_update() function now works when None is passed to the function.
Related issue number
#723
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.