test[fix]: Pass parameters to aiohttp correctly #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferenc-
force-pushed
the
aiohttp-parameter
branch
from
826ef3b
to
d673bf9
Compare
Apparently the parameter passing in our `aiohttp` tests were incorrect, and was depending on a `yarl` bug [1] that was fixed [2] in `1.9.0`, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latest `yarl`. [1] aio-libs/yarl#723 [2] aio-libs/yarl#792 Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
Ferenc-
force-pushed
the
aiohttp-parameter
branch
from
d673bf9
to
b2b6221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the parameter passing in our
aiohttptests were incorrect, and was depending on ayarlbug [1] that was fixed [2] in1.9.0, and with this new yarl version, our tests started to fail. This fix corrects the parameter passing, so we can use the latestyarl.[1] aio-libs/yarl#723
[2] aio-libs/yarl#792