Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid normalizing child paths when there are no dots in the path #1248

Merged
merged 5 commits into from
Oct 13, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 13, 2024

Avoid normalizing child paths when there are no dots in the path

This one will need quite a few more tests if benchmarks shows its worth working on

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (9107005) to head (6f6ab95).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1248      +/-   ##
==========================================
+ Coverage   95.80%   95.81%   +0.01%     
==========================================
  Files          27       27              
  Lines        5126     5142      +16     
  Branches      310      310              
==========================================
+ Hits         4911     4927      +16     
  Misses        189      189              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 95.79% <100.00%> (+0.01%) ⬆️
MyPy 43.68% <64.70%> (+0.06%) ⬆️
OS-Linux 99.35% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.41% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 98.96% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 98.96% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 98.91% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 99.18% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.91% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.18% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 99.23% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.23% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.26% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.06% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.35% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.41% <100.00%> (+<0.01%) ⬆️
pytest 99.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #1248 will improve performances by 8.44%

Comparing avoid_normalize_when_making_child_if_no_dot (6f6ab95) with master (9107005)

Summary

⚡ 2 improvements
✅ 39 untouched benchmarks

Benchmarks breakdown

Benchmark master avoid_normalize_when_making_child_if_no_dot Change
test_url_joinpath_encoded 1.6 ms 1.5 ms +7.77%
test_url_joinpath_with_truediv 1.9 ms 1.7 ms +8.44%

yarl/_url.py Show resolved Hide resolved
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 13, 2024
CHANGES/1248.misc.rst Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review October 13, 2024 02:15
@bdraco bdraco merged commit 404b542 into master Oct 13, 2024
49 of 51 checks passed
@bdraco bdraco deleted the avoid_normalize_when_making_child_if_no_dot branch October 13, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant