Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for calling update_query with a query string #1329

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 18, 2024

We only had benchmarks for calling with a Sequence or a Mapping. Add one for str

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 18, 2024
@bdraco bdraco changed the title Add benchmark for calling update_query with a query_string Add benchmark for calling update_query with a query string Oct 18, 2024
@bdraco bdraco marked this pull request as ready for review October 18, 2024 06:30
Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #1329 will not alter performance

Comparing benchmark_update_query_with_string (0743557) with master (8e445f4)

Summary

✅ 79 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark master benchmark_update_query_with_string Change
🆕 test_update_query_string N/A 754.4 µs N/A

@bdraco bdraco enabled auto-merge (squash) October 18, 2024 06:36
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (8e445f4) to head (0743557).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1329   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          27       27           
  Lines        5428     5434    +6     
  Branches      329      330    +1     
=======================================
+ Hits         5210     5216    +6     
  Misses        192      192           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.98% <100.00%> (+<0.01%) ⬆️
MyPy 44.50% <71.42%> (+0.02%) ⬆️
OS-Linux 99.32% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.37% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.05% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.03% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.03% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.98% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.23% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.28% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.30% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.05% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.32% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.37% <100.00%> (+<0.01%) ⬆️
pytest 99.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 1350a41 into master Oct 18, 2024
43 of 46 checks passed
@bdraco bdraco deleted the benchmark_update_query_with_string branch October 18, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant