-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performances of URL.joinpath
#1418
Conversation
bdraco
commented
Nov 17, 2024
•
edited
Loading
edited
- Avoid the slice for the common cases
- Avoid creating new lists
- Avoid reversing as long as possible so we do not have to insert at the front or create a new list since insert at 0 has O(n) time complexity, and append has O(1) time complexity
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1418 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 31 31
Lines 5773 5774 +1
Branches 347 348 +1
=======================================
+ Hits 5546 5547 +1
Misses 201 201
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #1418 will improve performances by 21.15%Comparing Summary
Benchmarks breakdown
|
a030acc
to
e444044
Compare
URL.joinpath