Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL::build(): Accept host-only URLs #217

Merged
merged 1 commit into from
Aug 11, 2018
Merged

Conversation

behnam
Copy link
Contributor

@behnam behnam commented Jul 13, 2018

Accept host-only URLs, which are buildable using the parsing method as
`//host-name'.

Also, add check for setting port without a host, along-side test case
for it.

@behnam
Copy link
Contributor Author

behnam commented Jul 13, 2018

This could be considered an API-breaking change, since a call previously raising error now doesn't do so, and some application logic may depend on it. What do you think?

Btw, what's the best way to track API-breaking changes here?

@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

Merging #217 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files           2        2           
  Lines         582      582           
  Branches      140      140           
=======================================
  Hits          580      580           
  Partials        2        2
Impacted Files Coverage Δ
yarl/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1cb2e0...d7ddec9. Read the comment docs.

Accept host-only URLs, which are buildable using the parsing method as
`//host-name'.

Also, add check for setting port without a host, along-side test case
for it.
@behnam
Copy link
Contributor Author

behnam commented Aug 9, 2018

#ping Would you like me to make any changes here?

@webknjaz
Copy link
Member

LGTM, but I'll leave it up to @asvetlov to consider consequences.

Regarding tracking changes it's probably just that the project follows semver. I'd also add entry to CHANGES.rst.

@asvetlov asvetlov merged commit 5258353 into aio-libs:master Aug 11, 2018
@asvetlov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants