Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Cython implementation for requoting a single percent. #515

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

serhiy-storchaka
Copy link
Contributor

Fixed cases "%%xx" and "%a%xx".

Closes #514.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 27, 2020
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #515 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   99.58%   99.72%   +0.14%     
==========================================
  Files           4        4              
  Lines         720      739      +19     
  Branches      160      168       +8     
==========================================
+ Hits          717      737      +20     
+ Misses          3        2       -1     
Impacted Files Coverage Δ
yarl/_url.py 99.64% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663a3c7...abe7afc. Read the comment docs.

@asvetlov asvetlov merged commit 7fbe2a8 into aio-libs:master Oct 12, 2020
@asvetlov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference between Python and Cython implementation of quoter
2 participants