-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added bytes conversion #582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 4 4
Lines 737 739 +2
Branches 165 165
=======================================
+ Hits 735 737 +2
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
It is interesting that said test also fails for the other Python versions. I am not convinced this has anything to do with the proposed changes, however.... |
Suggested typos are applied to master in a separate commit, thanks |
What do these changes do?
Added
__bytes__()
magic method so thatbytes(url)
will work and use optimal ASCII encoding, as URL string representations are always encoded already.While I was at it, I fixed some typos I saw and I had to add a mypy ignore for the tests to work for me. There is one test that fails for me (
test_semicolon_as_separator
) because I was using a Python > 3.9.2 andparse_qsl()
changed its behavior.Are there changes in behavior for the user?
Existing functionality shouldn't be affected.
Related issue number
n/a
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.