Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKI-603(647) AionPendingState refactoring #1101

Merged
merged 16 commits into from
Jan 23, 2020
Merged

AKI-603(647) AionPendingState refactoring #1101

merged 16 commits into from
Jan 23, 2020

Conversation

AionJayT
Copy link
Collaborator

Description

Fixes Issue # .

Type of change

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

@AionJayT AionJayT added the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Dec 17, 2019
@AionJayT AionJayT added this to the 1.2 milestone Dec 17, 2019
@AionJayT AionJayT self-assigned this Dec 17, 2019
@AionJayT AionJayT added the enhancement New feature or request label Dec 17, 2019
AlexandraRoatis
AlexandraRoatis reviewed Dec 18, 2019
View reviewed changes
modAionImpl/src/org/aion/zero/impl/blockchain/AionImpl.java Outdated Show resolved Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionImpl.java Outdated Show resolved Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionImpl.java Outdated Show resolved Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionHub.java Outdated Show resolved Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionHub.java Outdated Show resolved Hide resolved
modAionImpl/src/org/aion/zero/impl/pendingState/AionPendingStateImpl.java Outdated Show resolved Hide resolved
modAionImpl/test/org/aion/zero/impl/sync/BlockPropagationTest.java Outdated Show resolved Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionBlockchainImpl.java Outdated Show resolved Hide resolved
@AionJayT AionJayT modified the milestones: 1.2, 1.3 Jan 2, 2020
@AionJayT
Remove p2p dependency from the pendingPool
8baca86
@AionJayT
Rename best block in the pendingState
ddbcfff
@AionJayT
AKI-603 Removed bestblock access from the other class. Only update th…
de0b62e 
…e best block from the aionblockchain.

  - Also eemoved the fork0.4.0 checking into the forkUtility class and asking question from there.
@AionJayT
AKI-603 Simplified the blockchainImpl instances in the pendingState
609de9e
@AionJayT
AKI-603 Moved TransactionSortedSet class into AionHub
e4f2fe6
@AionJayT
AKI-603 Removed the broadcast call by AionImpl.inst in the pendingState
d0488c0
@AionJayT
AKI-603 Remove txBroadcastbuffer in pendingState
717311d 
  - Removed the bufferEnable in the CfgTx
@AionJayT
Moved seedmode setting from CfgConsensus to CfgTx and kept the compat…
4c91419 
…ibilities
@AionJayT
AKI-603 Removed CfgAion dependency in the pendingState
264b94f 
  - Renamed flags in the pendingState
  - Fixed the pendingNonce method under the seedmode
@AionJayT
AKI-603 Refactoring the poolBackup timing in the pendingState
689b1a9
@AionJayT
AKI-603 PendingState refactoring, unify the transaction validating path.
ff4303c 
  - Made transaction validation in the same layer, remove the validation in the addTransactions call, remove check in the broadcast layer.
  - Sepecified the transaction checks for 3 different entrances in the pendingstate, keep the same executing logic in the addTransactions.
  - Added TxResponse types
  - Fixed tests
@AionJayT AionJayT removed the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Jan 21, 2020
@AionJayT AionJayT changed the title AKI-603 AionPendingState refactoring AKI-647 AionPendingState refactoring Jan 22, 2020
@AionJayT AionJayT changed the title AKI-647 AionPendingState refactoring AKI-603 AionPendingState refactoring Jan 22, 2020
@AionJayT AionJayT changed the title AKI-603 AionPendingState refactoring AKI-603(647) AionPendingState refactoring Jan 22, 2020
@AionJayT AionJayT merged commit ff4303c into master Jan 23, 2020
@AionJayT AionJayT deleted the AKI-603 branch January 23, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandraRoatis AlexandraRoatis AlexandraRoatis approved these changes

@geoff-aion geoff-aion Awaiting requested review from geoff-aion

Assignees

@AionJayT AionJayT

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@AionJayT @AlexandraRoatis