Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKI-648 validate block timestamp in the block submit api #1109

Merged
merged 2 commits into from
Jan 28, 2020
Merged

AKI-648 validate block timestamp in the block submit api #1109

merged 2 commits into from
Jan 28, 2020

Conversation

AionJayT
Copy link
Collaborator

Description

Fixes Issue # .

Type of change

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

@AionJayT AionJayT added the bug Something isn't working label Jan 23, 2020
@AionJayT AionJayT added this to the 1.3 milestone Jan 23, 2020
@AionJayT AionJayT self-assigned this Jan 23, 2020
AlexandraRoatis
AlexandraRoatis reviewed Jan 24, 2020
View reviewed changes
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the updated jars in the tooling directory necessary?

modApiServer/src/org/aion/api/server/rpc3/AionChainHolder.java Outdated Show resolved Hide resolved
@AionJayT
Copy link
Collaborator Author

Are all the updated jars in the tooling directory necessary?
No, but the new tooling has less issue for creating staking block in the custom network. Also new tooling only has one jar instead of the externalStaker use a lot of jars

@AionJayT AionJayT force-pushed the AKI-648 branch 3 times, most recently from 0734f28 to 8c0ef9c Compare January 24, 2020 15:55
@AionJayT AionJayT merged commit 881a413 into master Jan 28, 2020
@AionJayT AionJayT deleted the AKI-648 branch January 28, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandraRoatis AlexandraRoatis AlexandraRoatis approved these changes

Assignees

@AionJayT AionJayT

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@AionJayT @AlexandraRoatis