web3 server-side changes (JSON RPC spec compliance + bug-fixes) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-sharif
commented
Mar 1, 2018
| @@ -169,8 +169,7 @@ private static JSONObject process(final IRpc.Method _method, final long _id, fin | |||
|
|
|||
| case eth_getWork: | |||
| // Header without nonce and solution , pool needs add new nonce | |||
| return processResult(_id, api.getBestBlock().getHeader().getHeaderBytes(true)); | |||
|
|
|||
| return processResult(_id, toHexString(HashUtil.h256(api.getBestBlock().getHeader().getHeaderBytes(true)))); | |||
There was a problem hiding this comment.
need review from @aion-6368726973 or @aion-Ross if this will break miner compatibility.
There was a problem hiding this comment.
There was a problem hiding this comment.
At this time it should not break the reference miners/pool as they are relying on the "getblocktemplate" call.
However why are we returning a hash of the block header? If we want to update this to return Equihash work we would need eth_getWork to return the entire block header. Our result will be quite different from the referenced eth_getWork.
aion-Ross
approved these changes
Mar 2, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
courtesy of Shidokht.
fix for #74