reLicense from GPLv3 to MIT #750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be easily excluded from builds via gradle.properties
AionJayT
requested review from
aion-kelvin,
AlexandraRoatis,
arajasek and
qoire
Cli port input
aion-kelvin
approved these changes
Dec 13, 2018
AlexandraRoatis
suggested changes
Dec 17, 2018
Isolate modGui and its build logic
- The unknown version test can fail on certain of the random inputs because it is casting what is effectively a short to a byte, and the short will get truncated on large inputs. Two of these truncated results will be 0 and 1, which are the two numbers this test is expressly trying to avoid, because they are supposed to fail. - The random range is now bound above by Byte.MAX_VALUE so that this truncating does not occur anymore.
arajasek
approved these changes
Dec 17, 2018
AlexandraRoatis
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.
Description
Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.
Re-license from GPLv3 to MIT, the contributor list might need to modify.
Fixes Issue # .
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.
Verification
Insert x into the following checkboxes to confirm (eg. [x]):