-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AIP-203): introduce IDENTIFIER field behavior #1201
feat(AIP-203): introduce IDENTIFIER field behavior #1201
Conversation
Making it a bit easier to find the appropriate field behavior with alphabetical sorting.
Identifier fields are often multi-modal: they are required or optional in various situations. Adding an explicit field behavior for these fields helps eliminate ambiguity for an author to fully annotate field behavior on all request fields, as well as clarify which fields to use in identifying the resource for clients. fixes aip-dev#1176.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include the Compatibility guidance in here as well (you documented it in the proposal doc).
Also, can you update other AIPs that portray the google.api.resource
with a name
field to include the IDENTIFIER value?
Just friendly reminder that these would be nice too :) At least the first one. |
good calls! done. On the meta level: I think we have |
Oh man yeah there are a lot of spots...perhaps you are right this could be annoying to update in the future as well. |
- updating name examples with the field behavior - adding backwards compatibility considerations
25256d3
to
2bac311
Compare
done and done! please take another look. |
Identifier fields are often multi-modal: they are required or optional
in various situations. Adding an explicit field behavior for these
fields helps eliminate ambiguity for an author to fully annotate field
behavior on all request fields, as well as clarify which fields to use
in identifying the resource for clients.
fixes #1176.