Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature (interpreted functions) #626

Open
wants to merge 62 commits into
base: master
Choose a base branch
from

Conversation

Ezpeon
Copy link

@Ezpeon Ezpeon commented Sep 11, 2024

No description provided.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 83.84774% with 157 lines in your changes missing coverage. Please review.

Project coverage is 85.27%. Comparing base (fec0d86) to head (49dd2d1).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
unified_planning/model/interpreted_function.py 63.41% 45 Missing ⚠️
...engines/compilers/interpreted_functions_remover.py 84.00% 32 Missing ⚠️
..._planning/engines/interpreted_functions_planner.py 78.87% 30 Missing ⚠️
...lanning/test/test_interpreted_functions_planner.py 60.60% 26 Missing ⚠️
unified_planning/test/test_anytime.py 46.66% 8 Missing ⚠️
unified_planning/engines/plan_validator.py 73.33% 4 Missing ⚠️
unified_planning/model/expression.py 70.00% 3 Missing ⚠️
unified_planning/model/walkers/simplifier.py 84.21% 3 Missing ⚠️
unified_planning/model/walkers/type_checker.py 77.77% 2 Missing ⚠️
unified_planning/engines/sequential_simulator.py 95.23% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
- Coverage   85.32%   85.27%   -0.05%     
==========================================
  Files         202      208       +6     
  Lines       27286    28247     +961     
==========================================
+ Hits        23281    24087     +806     
- Misses       4005     4160     +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Samuel Gobbi added 27 commits September 12, 2024 10:41
…nml cannot handle these test cases as of now
…yer of ands in preconditions for instantaneous actions
Samuel Gobbi added 30 commits September 24, 2024 10:02
… problems and returns error if not straightforwardly solvable
…ditions - this breaks test_partial_order_plan
…ation for some walkers - added skip for IFs
…added check if plan is None then skip tests
…- seems to consistently verify that anytime works for small problems, large problems often cause internal errors in the planner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant