replace goal with an action to achieve an artificial goal #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvalentini
reviewed
Oct 27, 2023
| @@ -257,3 +259,82 @@ def supports(problem_kind: "ProblemKind") -> bool: | |||
| @staticmethod | |||
| def satisfies(optimality_guarantee: OptimalityGuarantee) -> bool: | |||
| return True | |||
|
|
|||
| # To avoid the introduction of axioms with complicated goals, we introduce | |||
There was a problem hiding this comment.
@roeger Does this add any overhead?
If yes, maybe you can avoid the introduction of this extra action when complicated goals are not present.
There was a problem hiding this comment.
The overhead is negligible. I will still consider to only apply it only when necessary for the grounder because there I don't know what will happen to the task afterwards.
--------- Co-authored-by: Gabriele Roeger <gabriele.roeger@unibas.ch>
* fix bug in Fast Downward reachability grounder * fix simplifier creation in Fast Downward grounder * silence internal Fast Downward output in grounders --------- Co-authored-by: Luca Framba <framba@fbk.eu>
If the goal is not a conjunction of literals, Fast Downward introduces axioms to handle it. To avoid this, we instead introduce an artificial goal action (removed when mapping back). There can be several ground representatives of the artificial goal action in the compiled task (e.g. from disjunctive preconditions). We now give each instance an individual name.
|
This branch passes all tests from the main repo. The Changelog is still missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Framba-Luca. This is the kind of transformation I had in mind for reducing the introduction of axioms. Can you have a look?