Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected fix to hlsparser by Sheen Tian (March 5, 2020) #11

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

fduncanh
Copy link
Contributor

Don't know if this has any significance, but this is the correct form of a fix to hlsparser code made on March 5, 2020

Copy link
Member

@tishion tishion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM!

@tishion
Copy link
Member

tishion commented Jul 18, 2024

I have one question, why is your commit always not signed?
This blocked the PR to be merged, every time I need to change the setting then merge your PR and then revert the setting change

@tishion
Copy link
Member

tishion commented Jul 18, 2024

The base branch requires all commits to be signed. Learn more about signing commits.

@tishion tishion merged commit e7aba62 into air-display:main Jul 18, 2024
5 checks passed
@fduncanh
Copy link
Contributor Author

The base branch requires all commits to be signed. Learn more about signing commits.

wasn't aware of this. sorry.

@fduncanh fduncanh deleted the hlsparser_fix branch December 28, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants