Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix *significant* typo Inster -> Insert #8

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

fduncanh
Copy link
Contributor

@fduncanh fduncanh commented Jun 17, 2024

This is a significant typo.

I am using your c++ class ap_casting_media_store verbatim (with the hlsparse library) , through extern "C" wrappers to and from C, with http handlers in C that are functionally-equivalent to your handlers, and an extern "C" implementation of send_fcup_request.

The first POST /action request I see after POST /play is of Action type "playlistInsert" not "unhandledURLResponse"

Unfortunately, your code tests the Action type against "playlistInster" so misses it because of the typo (and I have no model to follow for implementing this action because it is unimplemented in your code).

  • there are a number of "cosmetic" other typos (hanlder for handler, meida for media , plus others) that I noticed. Would you like a Pull Request to fix these?

  • any suggestions on handling these unhandled action types playlistInsert and playlistRemove?

Copy link
Member

@tishion tishion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting my fat finger

@tishion tishion merged commit 6ea955a into air-display:main Jun 18, 2024
5 checks passed
@fduncanh fduncanh deleted the playlistInsert branch June 18, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants